From reviews-return-9113-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Sep 9 14:46:29 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C3CF417A57 for ; Wed, 9 Sep 2015 14:46:29 +0000 (UTC) Received: (qmail 85610 invoked by uid 500); 9 Sep 2015 14:46:23 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 85589 invoked by uid 500); 9 Sep 2015 14:46:23 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 85574 invoked by uid 99); 9 Sep 2015 14:46:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Sep 2015 14:46:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8EE0327220D; Wed, 9 Sep 2015 14:46:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0110103383244022638==" MIME-Version: 1.0 Subject: Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs. From: "Alexander Rukletsov" To: "Michael Park" , "haosdent huang" , "Joseph Wu" Cc: "Alexander Rukletsov" , "Mesos ReviewBot" , "mesos" Date: Wed, 09 Sep 2015 14:46:22 -0000 Message-ID: <20150909144622.1695.62271@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Rukletsov" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37827/ X-Sender: "Alexander Rukletsov" References: <20150907091205.12750.50807@reviews.apache.org> In-Reply-To: <20150907091205.12750.50807@reviews.apache.org> Reply-To: "Alexander Rukletsov" X-ReviewRequest-Repository: mesos --===============0110103383244022638== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/ ----------------------------------------------------------- (Updated Sept. 9, 2015, 2:46 p.m.) Review request for mesos, haosdent huang, Joseph Wu, and Michael Park. Changes ------- Rebased. Bugs: MESOS-3312 https://issues.apache.org/jira/browse/MESOS-3312 Repository: mesos Description ------- See summary. Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3098293eb3659b3066f10e875927ec3ac3 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h cfc2803e42284f641879fb24bce1282215c8ea52 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc a1d4084661345f9367c75f9db61279f032b93e69 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto bbd36d39e9588eb8eea6d739451ad3bab029ca08 Diff: https://reviews.apache.org/r/37827/diff/ Testing ------- make check (Mac OS 10.10.4) **NOTE**: Filed [MESOS-3323](https://issues.apache.org/jira/browse/MESOS-3323) to clean up protobuf generation. Thanks, Alexander Rukletsov --===============0110103383244022638==--