| Ben Mahler |
Re: Review Request 38416: Allow HTTP response codes to be checked with code. |
Wed, 16 Sep, 22:42 |
| Ben Mahler |
Re: Review Request 38046: mesos: Replaced hard-coded reap interval with a constant. |
Wed, 16 Sep, 23:03 |
| Ben Mahler |
Re: Review Request 38046: mesos: Replaced hard-coded reap interval with a constant. |
Wed, 16 Sep, 23:04 |
| Ben Mahler |
Re: Review Request 38168: libprocess: Replaced hard-coded reap interval with a constant. |
Wed, 16 Sep, 23:09 |
| Ben Mahler |
Re: Review Request 38416: Allow HTTP response codes to be checked with code. |
Wed, 16 Sep, 23:11 |
| Ben Mahler |
Re: Review Request 38046: mesos: Replaced hard-coded reap interval with a constant. |
Wed, 16 Sep, 23:12 |
| Ben Mahler |
Re: Review Request 37931: Update indent for slave.cpp |
Wed, 16 Sep, 23:47 |
| Ben Mahler |
Re: Review Request 38102: MESOS-3046 (Stout's UUID re-seeds a new random generator during each call to UUID::random) |
Fri, 18 Sep, 04:15 |
| Ben Mahler |
Re: Review Request 38481: Fix UUID::random compile error in OSX. |
Fri, 18 Sep, 16:23 |
| Ben Mahler |
Re: Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers. |
Mon, 21 Sep, 23:01 |
| Ben Mahler |
Review Request 38595: Removed implicit logging from Socket::shutdown in favor of returning a Try. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38596: Updated http::URL to be a URI-reference. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38597: Added URL within http::Request. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38598: Updates to reflect addition of URL in http::Request. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38600: Introduced a typedef to make consistent use of case-insentitive http headers easier. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38599: Consistent use of case insensitive keys for HTTP headers. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38601: Added a TODO to keep Request.keepAlive consistent with the 'Connection' header value. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38603: Refactored http::internal::Request to take a Request object. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38604: Re-enabled decoder test for case insensitive headers. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38605: Improved streaming decoder tests by checking the failed state. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38606: Added ability to check if the streaming decoder is writing to a body pipe. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38607: Pulled out an encode function for http::Request encoding. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38608: Introduced an http::Connection for connection re-use and pipelining. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Review Request 38609: Refactored http::internal::request to use http::connect. |
Tue, 22 Sep, 06:18 |
| Ben Mahler |
Re: Review Request 38452: Updated C++ style guide for namespace usage |
Wed, 23 Sep, 17:47 |
| Ben Mahler |
Re: Review Request 38416: Allow HTTP response codes to be checked with code. |
Wed, 23 Sep, 18:26 |
| Ben Mahler |
Re: Review Request 38158: Refactored Value::Ranges coalesce(). |
Wed, 23 Sep, 18:29 |
| Ben Mahler |
Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd. |
Wed, 23 Sep, 21:36 |
| Ben Mahler |
Re: Review Request 38699: stout: use os::close everywhere. |
Thu, 24 Sep, 00:30 |
| Ben Mahler |
Review Request 38729: Do not retry close on EINTR. |
Thu, 24 Sep, 19:41 |
| Ben Mahler |
Review Request 38730: Do not retry close on EINTR. |
Thu, 24 Sep, 19:41 |
| Ben Mahler |
Re: Review Request 38728: Cgroups Test Filters aborts test. |
Thu, 24 Sep, 19:43 |
| Ben Mahler |
Re: Review Request 38729: Do not retry close on EINTR. |
Thu, 24 Sep, 22:01 |
| Ben Mahler |
Re: Review Request 38726: Make common attributes symmetrical to v1 attributes. |
Thu, 24 Sep, 22:11 |
| Ben Mahler |
Re: Review Request 38731: Make common resources symmetrical to v1 resources. |
Thu, 24 Sep, 22:22 |
| Ben Mahler |
Re: Review Request 38743: files: fix potential fd leaks under error conditions. |
Fri, 25 Sep, 01:15 |
| Ben Mahler |
Re: Review Request 38770: routing: fixed a file descriptor leak. |
Fri, 25 Sep, 19:52 |
| Ben Mahler |
Review Request 38775: Removed unnecessary close calls on ifstream and ofstream. |
Fri, 25 Sep, 21:56 |
| Ben Mahler |
Review Request 38776: Removed unnecessary close calls on ifstream and ofstream. |
Fri, 25 Sep, 21:56 |
| Ben Mahler |
Review Request 38777: Avoid closing '-1' file descriptors in Subprocess. |
Fri, 25 Sep, 22:14 |
| Ben Mahler |
Re: Review Request 38416: Allow HTTP response codes to be checked with code. |
Fri, 25 Sep, 22:52 |
| Ben Mahler |
Re: Review Request 38774: state: fix file descriptor leak |
Fri, 25 Sep, 22:57 |
| Ben Mahler |
Re: Review Request 38780: io: fixed a file descriptor leak in peek() |
Fri, 25 Sep, 23:40 |
| Ben Mahler |
Re: Review Request 38596: Updated http::URL to be a URI-reference. |
Mon, 28 Sep, 18:27 |
| Ben Mahler |
Re: Review Request 38597: Added URL within http::Request. |
Mon, 28 Sep, 18:27 |
| Ben Mahler |
Re: Review Request 38810: poll_socket: fix a file descriptor leak under error condition. |
Mon, 28 Sep, 18:46 |
| Ben Mahler |
Review Request 38817: Added a SIGPIPE handler for the libprocess tests. |
Mon, 28 Sep, 19:29 |
| Ben Mahler |
Re: Review Request 38819: Fixed a bug in cgroups test filter. |
Mon, 28 Sep, 19:56 |
| Ben Mahler |
Re: Review Request 38817: Added a SIGPIPE handler for the libprocess tests. |
Tue, 29 Sep, 00:12 |
| Ben Mahler |
Re: Review Request 38823: io: fixed a file descriptor leak in io::redirect. |
Tue, 29 Sep, 00:26 |
| Ben Mahler |
Re: Review Request 38774: state: fix file descriptor leak |
Tue, 29 Sep, 00:28 |
| Ben Mahler |
Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling. |
Tue, 29 Sep, 00:31 |
| Ben Mahler |
Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks. |
Tue, 29 Sep, 00:47 |
| Ben Mahler |
Re: Review Request 38835: Ignore SIGPIPE when finalizing libevent. |
Tue, 29 Sep, 01:51 |
| Ben Mahler |
Re: Review Request 38328: Added a helper to get stat.st_dev in stout. |
Tue, 29 Sep, 18:32 |
| Ben Mahler |
Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments. |
Tue, 29 Sep, 19:12 |
| Ben Mahler |
Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling. |
Tue, 29 Sep, 19:23 |
| Ben Mahler |
Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks. |
Tue, 29 Sep, 19:57 |
| Ben Mahler |
Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks. |
Tue, 29 Sep, 20:01 |
| Ben Mahler |
Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks. |
Tue, 29 Sep, 21:29 |
| Ben Mahler |
Re: Review Request 38747: Adding digest utilities |
Tue, 29 Sep, 21:35 |
| Ben Mahler |
Re: Review Request 38747: Adding digest utilities |
Tue, 29 Sep, 22:35 |
| Ben Mahler |
Re: Review Request 38452: Updated C++ style guide for namespace usage |
Tue, 29 Sep, 22:53 |
| Ben Mahler |
Re: Review Request 38452: Updated C++ style guide for namespace usage |
Tue, 29 Sep, 23:30 |
| Ben Mahler |
Re: Review Request 38452: Updated C++ style guide for namespace usage |
Tue, 29 Sep, 23:47 |
| Ben Mahler |
Re: Review Request 38869: Added static->dynamic transformation to Allocator. |
Wed, 30 Sep, 21:33 |
| Benjamin Hindman |
Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter. |
Thu, 10 Sep, 03:00 |
| Benjamin Hindman |
Re: Review Request 37177: Maintenance Primitives: Added inverse offers. |
Thu, 10 Sep, 03:41 |
| Benjamin Hindman |
Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct. |
Fri, 11 Sep, 02:06 |
| Benjamin Hindman |
Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master. |
Fri, 11 Sep, 02:10 |
| Benjamin Hindman |
Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator. |
Fri, 11 Sep, 02:11 |
| Benjamin Hindman |
Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master. |
Mon, 14 Sep, 03:02 |
| Benjamin Hindman |
Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance. |
Mon, 14 Sep, 03:05 |
| Benjamin Hindman |
Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct. |
Mon, 14 Sep, 03:12 |
| Benjamin Hindman |
Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master. |
Mon, 14 Sep, 03:13 |
| Benjamin Hindman |
Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter. |
Mon, 14 Sep, 03:14 |
| Benjamin Hindman |
Re: Review Request 37177: Maintenance Primitives: Added inverse offers. |
Mon, 14 Sep, 03:15 |
| Benjamin Hindman |
Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API. |
Mon, 14 Sep, 03:19 |
| Benjamin Hindman |
Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master. |
Mon, 14 Sep, 03:24 |
| Benjamin Hindman |
Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler. |
Mon, 14 Sep, 03:27 |
| Benjamin Hindman |
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started. |
Mon, 14 Sep, 03:36 |
| Benjamin Hindman |
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started. |
Mon, 14 Sep, 03:39 |
| Benjamin Hindman |
Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance. |
Mon, 14 Sep, 03:47 |
| Benjamin Hindman |
Re: Review Request 38473: Add flag to disable hostname lookup. |
Mon, 21 Sep, 19:39 |
| Benjamin Hindman |
Re: Review Request 38473: Add flag to disable hostname lookup. |
Wed, 23 Sep, 22:01 |
| Benjamin Hindman |
Re: Review Request 38634: Added Systemd environment check to LinuxLauncher. |
Thu, 24 Sep, 00:41 |
| Benjamin Hindman |
Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd. |
Thu, 24 Sep, 00:57 |
| Benjamin Hindman |
Re: Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd. |
Thu, 24 Sep, 00:58 |
| Benjamin Hindman |
Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd. |
Thu, 24 Sep, 01:00 |
| Benjamin Hindman |
Re: Review Request 38733: Make common type_utils symmetrical to v1 mesos. |
Thu, 24 Sep, 23:37 |
| Benjamin Hindman |
Re: Review Request 38731: Make common resources symmetrical to v1 resources. |
Thu, 24 Sep, 23:37 |
| Benjamin Hindman |
Re: Review Request 38727: Make common values symmetrical to v1 values. |
Thu, 24 Sep, 23:37 |
| Benjamin Hindman |
Re: Review Request 38726: Make common attributes symmetrical to v1 attributes. |
Thu, 24 Sep, 23:37 |
| Benjamin Hindman |
Re: Review Request 38738: Make common public header type_utils symmetrical to v1 mesos. |
Fri, 25 Sep, 00:03 |
| Bernd Mathiske |
Re: Review Request 37669: Ignore overflow docker components in version parsing. |
Wed, 02 Sep, 14:54 |
| Bernd Mathiske |
Re: Review Request 37669: Ignore overflow docker components in version parsing. |
Thu, 03 Sep, 11:11 |
| Bernd Mathiske |
Review Request 38125: Included hostname in SlaveID. |
Fri, 04 Sep, 10:57 |
| Bernd Mathiske |
Re: Review Request 38125: Included hostname in SlaveID. |
Fri, 04 Sep, 13:15 |
| Bernd Mathiske |
Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset. |
Tue, 08 Sep, 09:18 |
| Bernd Mathiske |
Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset. |
Tue, 08 Sep, 09:18 |