| Mesos ReviewBot |
Re: Review Request 38774: state: fix file descriptor leak |
Fri, 25 Sep, 21:38 |
| Mesos ReviewBot |
Re: Review Request 38776: Removed unnecessary close calls on ifstream and ofstream. |
Fri, 25 Sep, 22:37 |
| Mesos ReviewBot |
Re: Review Request 38779: Use new HTTP status code check in scheduler. |
Fri, 25 Sep, 23:53 |
| Mesos ReviewBot |
Re: Review Request 38756: CMake: Add support for compiling the agent with CMake. |
Sat, 26 Sep, 00:48 |
| Mesos ReviewBot |
Re: Review Request 37531: MESOS-3070 (Master CHECK failure if a framework uses duplicated task id) |
Sat, 26 Sep, 04:12 |
| Mesos ReviewBot |
Re: Review Request 38667: Added a test for os::realpath(). |
Sat, 26 Sep, 08:45 |
| Mesos ReviewBot |
Re: Review Request 38756: CMake: Add support for compiling the agent with CMake. |
Sat, 26 Sep, 22:59 |
| Mesos ReviewBot |
Re: Review Request 38793: CMake: Transition to CMake-based build system for GMock/GTest. |
Sun, 27 Sep, 00:09 |
| Mesos ReviewBot |
Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py). |
Sun, 27 Sep, 03:04 |
| Mesos ReviewBot |
Re: Review Request 38160: Documented how to expedite event firing. |
Mon, 28 Sep, 17:57 |
| Mesos ReviewBot |
Re: Review Request 38810: poll_socket: fix a file descriptor leak under error condition. |
Mon, 28 Sep, 19:09 |
| Mesos ReviewBot |
Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks. |
Mon, 28 Sep, 20:09 |
| Mesos ReviewBot |
Re: Review Request 38814: add test cases for sha512 digest verifier |
Mon, 28 Sep, 20:39 |
| Mesos ReviewBot |
Re: Review Request 38816: add test case for docker remotePuller |
Mon, 28 Sep, 20:59 |
| Mesos ReviewBot |
Re: Review Request 38817: Added a SIGPIPE handler for the libprocess tests. |
Mon, 28 Sep, 22:06 |
| Mesos ReviewBot |
Re: Review Request 38774: state: fix file descriptor leak |
Mon, 28 Sep, 23:01 |
| Mesos ReviewBot |
Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253 |
Mon, 28 Sep, 23:18 |
| Mesos ReviewBot |
Re: Review Request 38822: Added default upgrade steps to 0.24.X to 0.25.X section |
Tue, 29 Sep, 00:14 |
| Mesos ReviewBot |
Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks. |
Tue, 29 Sep, 01:25 |
| Mesos ReviewBot |
Re: Review Request 38827: CMake: Expanded support for compiling much of the master. |
Tue, 29 Sep, 02:19 |
| Mesos ReviewBot |
Re: Review Request 38815: Add Zookeeper patch from ZOOKEEPER-2253 |
Tue, 29 Sep, 03:12 |
| Mesos ReviewBot |
Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling. |
Tue, 29 Sep, 04:15 |
| Mesos ReviewBot |
Re: Review Request 38837: CMake: Disable slave build on Windows. |
Tue, 29 Sep, 05:13 |
| Mesos ReviewBot |
Re: Review Request 38855: Added support for getting shared and slave mount peer group ID. |
Tue, 29 Sep, 18:16 |
| Mesos ReviewBot |
Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks. |
Tue, 29 Sep, 19:17 |
| Mesos ReviewBot |
Re: Review Request 38468: docs: Added discussion of finding a shepherd. |
Tue, 29 Sep, 20:23 |
| Mesos ReviewBot |
Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used. |
Tue, 29 Sep, 21:17 |
| Mesos ReviewBot |
Re: Review Request 38837: CMake: Disable agent build on Windows. |
Tue, 29 Sep, 22:17 |
| Mesos ReviewBot |
Re: Review Request 38860: Linked more doc pages from home.md. |
Tue, 29 Sep, 23:10 |
| Mesos ReviewBot |
Re: Review Request 38844: Added unit tests for Call validation in Agent |
Wed, 30 Sep, 00:12 |
| Mesos ReviewBot |
Re: Review Request 38869: Added static->dynamic transformation to Allocator. |
Wed, 30 Sep, 01:06 |
| Mesos ReviewBot |
Re: Review Request 38074: Calculate schedule latency with trace events |
Wed, 30 Sep, 02:00 |
| Mesos ReviewBot |
Re: Review Request 38870: Fixed a bug related to reviewboard_url option in post-reviews.py. |
Wed, 30 Sep, 02:50 |
| Mesos ReviewBot |
Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API |
Wed, 30 Sep, 05:02 |
| Mesos ReviewBot |
Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages. |
Wed, 30 Sep, 07:07 |
| Mesos ReviewBot |
Re: Review Request 38884: Added log message when suppress offers |
Wed, 30 Sep, 16:17 |
| Mesos ReviewBot |
Re: Review Request 38094: Added implementation of Http Basic authentication scheme. |
Wed, 30 Sep, 17:15 |
| Mesos ReviewBot |
Re: Review Request 38899: Added handler for Executor->Framework message for the Executor HTTP API |
Wed, 30 Sep, 18:14 |
| Mesos ReviewBot |
Re: Review Request 38900: Update command executor to support rootfs. |
Wed, 30 Sep, 19:16 |
| Mesos ReviewBot |
Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages. |
Wed, 30 Sep, 20:10 |
| Mesos ReviewBot |
Re: Review Request 38901: Serialize Docker Image Spec as Protobuf |
Wed, 30 Sep, 21:08 |
| Michael Park |
Re: Review Request 37168: MESOS-3063 |
Tue, 01 Sep, 03:34 |
| Michael Park |
Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs. |
Thu, 03 Sep, 20:37 |
| Michael Park |
Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs. |
Thu, 03 Sep, 21:26 |
| Michael Park |
Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs. |
Thu, 03 Sep, 21:29 |
| Michael Park |
Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs. |
Thu, 03 Sep, 23:32 |
| Michael Park |
Re: Review Request 37168: MESOS-3063 |
Fri, 04 Sep, 01:15 |
| Michael Park |
Re: Review Request 38118: Fix webui display problems when starting lots of tasks with small cpu value. |
Fri, 04 Sep, 15:32 |
| Michael Park |
Re: Review Request 37814: Added documentation for libprocess environment variables |
Fri, 04 Sep, 15:45 |
| Michael Park |
Re: Review Request 37814: Added documentation for libprocess environment variables |
Fri, 04 Sep, 16:16 |
| Michael Park |
Re: Review Request 35702: Added /reserve HTTP endpoint to the master. |
Fri, 04 Sep, 23:19 |
| Michael Park |
Re: Review Request 35983: Added /unreserve HTTP endpoint to the master. |
Fri, 04 Sep, 23:20 |
| Michael Park |
Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints. |
Wed, 09 Sep, 22:12 |
| Michael Park |
Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints. |
Wed, 09 Sep, 22:22 |
| Michael Park |
Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints. |
Wed, 09 Sep, 22:27 |
| Michael Park |
Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset. |
Wed, 09 Sep, 23:46 |
| Michael Park |
Re: Review Request 37968: Add more comments for why not using const reference for some functions |
Thu, 10 Sep, 07:56 |
| Michael Park |
Re: Review Request 37821: Join threads in libprocess when shutting down. |
Thu, 10 Sep, 08:20 |
| Michael Park |
Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs. |
Thu, 10 Sep, 08:44 |
| Michael Park |
Re: Review Request 37830: Added a test for converting JSON arrays to Resources. |
Thu, 10 Sep, 09:09 |
| Michael Park |
Re: Review Request 38154: Switched to type traits for checking whether a type is a protobuf message. |
Thu, 10 Sep, 09:10 |
| Michael Park |
Re: Review Request 37586: Generate usage help information in libprocess. |
Thu, 10 Sep, 09:20 |
| Michael Park |
Re: Review Request 37589: Remove unnecessary usage information. |
Thu, 10 Sep, 09:28 |
| Michael Park |
Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs. |
Thu, 10 Sep, 09:54 |
| Michael Park |
Review Request 38282: Fixed flaky ReservationEndpointsTest.AvailableResources test. |
Fri, 11 Sep, 00:50 |
| Michael Park |
Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs. |
Fri, 11 Sep, 01:25 |
| Michael Park |
Re: Review Request 38305: Stout: Removed namespace pollution. |
Fri, 11 Sep, 20:10 |
| Michael Park |
Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation) |
Sat, 12 Sep, 17:25 |
| Michael Park |
Re: Review Request 38306: Libprocess: Removed namespace pollution from ssl gtest. |
Mon, 14 Sep, 18:42 |
| Michael Park |
Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions. |
Mon, 14 Sep, 19:31 |
| Michael Park |
Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions. |
Mon, 14 Sep, 19:48 |
| Michael Park |
Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs. |
Tue, 15 Sep, 08:01 |
| Michael Park |
Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions. |
Tue, 15 Sep, 08:41 |
| Michael Park |
Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions. |
Tue, 15 Sep, 18:34 |
| Michael Park |
Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions. |
Tue, 15 Sep, 18:38 |
| Michael Park |
Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint |
Fri, 18 Sep, 18:14 |
| Michael Park |
Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables |
Fri, 18 Sep, 20:03 |
| Michael Park |
Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset. |
Fri, 18 Sep, 23:48 |
| Michael Park |
Re: Review Request 38158: Refactored Value::Ranges coalesce(). |
Wed, 23 Sep, 00:58 |
| Michael Park |
Re: Review Request 38158: Refactored Value::Ranges coalesce(). |
Wed, 23 Sep, 01:28 |
| Michael Park |
Re: Review Request 38158: Refactored Value::Ranges coalesce(). |
Wed, 23 Sep, 10:38 |
| Michael Park |
Re: Review Request 38158: Refactored Value::Ranges coalesce(). |
Wed, 23 Sep, 10:43 |
| Michael Park |
Re: Review Request 38158: Refactored Value::Ranges coalesce(). |
Wed, 23 Sep, 12:04 |
| Michael Park |
Re: Review Request 38158: Refactored Value::Ranges coalesce(). |
Wed, 23 Sep, 17:48 |
| Michael Park |
Re: Review Request 38749: Added `image_providers` flags to configuration.md. |
Fri, 25 Sep, 05:12 |
| Neil Conway |
Re: Review Request 37989: Replace hard-coded reap interval with a constant |
Tue, 01 Sep, 05:02 |
| Neil Conway |
Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic. |
Wed, 09 Sep, 17:39 |
| Neil Conway |
Re: Review Request 37876: stout: Replace GCC intrinsics with std::atomic. |
Wed, 09 Sep, 18:03 |
| Neil Conway |
Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix. |
Thu, 10 Sep, 05:07 |
| Neil Conway |
Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix. |
Thu, 10 Sep, 05:07 |
| Neil Conway |
Re: Review Request 37876: stout: Replace GCC intrinsics with std::atomic. |
Thu, 10 Sep, 18:53 |
| Neil Conway |
Review Request 38265: mesos: Update style guide for usage of std::atomic. |
Thu, 10 Sep, 18:53 |
| Neil Conway |
Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic. |
Thu, 10 Sep, 18:54 |
| Neil Conway |
Re: Review Request 37878: mesos: Replace volatile with std::atomic. |
Thu, 10 Sep, 18:55 |
| Neil Conway |
Review Request 38325: mesos: Add high-level description to persistent volume docs. |
Fri, 11 Sep, 22:55 |
| Neil Conway |
Review Request 38343: mesos: Fixed punctuation in log message. |
Mon, 14 Sep, 05:09 |
| Neil Conway |
Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix. |
Tue, 15 Sep, 21:10 |
| Neil Conway |
Review Request 38468: docs: Added discussion of finding a shepherd. |
Thu, 17 Sep, 18:54 |
| Neil Conway |
Re: Review Request 38468: docs: Added discussion of finding a shepherd. |
Thu, 17 Sep, 21:28 |
| Neil Conway |
Re: Review Request 38473: Add flag to disable hostname lookup. |
Fri, 18 Sep, 21:56 |