mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Klaus Ma <kl...@cguru.net>
Subject Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)
Date Wed, 09 Sep 2015 03:04:56 GMT
Hi Michael,

Do you have more comments about this example?

On 2015年09月06日 21:28, Klaus Ma wrote:
> This is an automatically generated e-mail. To reply, visit: 
> https://reviews.apache.org/r/37168/
>
>
>     On September 6th, 2015, 8:49 a.m. UTC, *Joerg Schad* wrote:
>
>         src/Makefile.am
>         <https://reviews.apache.org/r/37168/diff/4/?file=1064719#file1064719line1463>
>         (Diff revision 4)
>
>         	
>         	1463 	
>
>         Any reason for this blank line here?
>
> It's not necessary, will delete it.
>
>
>     On September 6th, 2015, 8:49 a.m. UTC, *Joerg Schad* wrote:
>
>         src/examples/dynamic_reservation_framework.cpp
>         <https://reviews.apache.org/r/37168/diff/4/?file=1064720#file1064720line281>
>         (Diff revision 4)
>
>         	
>         	281 	
>
>              START,       // The framework get the offer for the first time.
>
>         s/get/receives
>
> OK :).
>
>
>     On September 6th, 2015, 8:49 a.m. UTC, *Joerg Schad* wrote:
>
>         src/examples/dynamic_reservation_framework.cpp
>         <https://reviews.apache.org/r/37168/diff/4/?file=1064720#file1064720line283>
>         (Diff revision 4)
>
>         	
>         	283 	
>
>              TASK_DONE,   // All tasks are done.
>
>         s/TASK_DONE/TASKS_DONE
>
>
>         Please correct me if I am wrong: TASK_DONE is a global state
>         across all slaves, while the other states can differ per
>         state, or? Maybe just extend the comment a bit explaining this.
>
> Yes, TASK_DONE is a global state; when all task finished, framework 
> will un-reserve all resources.
>
>
>     On September 6th, 2015, 8:49 a.m. UTC, *Joerg Schad* wrote:
>
>         src/tests/dynamic_reservation_framework_test.sh
>         <https://reviews.apache.org/r/37168/diff/4/?file=1064721#file1064721line30>
>         (Diff revision 4)
>
>         	
>         	30 	
>
>         export MESOS_ROLES="test"
>
>         Do we need this here and below in script.cpp?
>
> Yes, it's necessary because: 1. dynamic reservation is role based 2. 
> can not use default role for dynamic reservation, neither * nor 
> MESOS_DEFAULT_ROLE
>
>
> - Klaus
>
>
> On September 6th, 2015, 4:11 a.m. UTC, Klaus Ma wrote:
>
> Review request for mesos and Michael Park.
> By Klaus Ma.
>
> /Updated Sept. 6, 2015, 4:11 a.m./
>
> *Bugs: * MESOS-3063 <https://issues.apache.org/jira/browse/MESOS-3063>
> *Repository: * mesos
>
>
>   Description
>
> Provide example for dynamic reservation features.
>
>
>   Testing
>
> make make check
>
>
>   Diffs
>
>   * src/Makefile.am (5fdca0f)
>   * src/examples/dynamic_reservation_framework.cpp (PRE-CREATION)
>   * src/tests/dynamic_reservation_framework_test.sh (PRE-CREATION)
>   * src/tests/examples_tests.cpp (3f56b30)
>   * src/tests/flags.hpp (06da36d)
>   * src/tests/script.cpp (bcc1fab)
>
> View Diff <https://reviews.apache.org/r/37168/diff/>
>

-- 
Klaus Ma (马达), PMP® | http://www.cguru.net


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message