mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 38577: Added synchronous validation for Call in Agent
Date Tue, 29 Sep 2015 21:24:25 GMT


> On Sept. 29, 2015, 8:29 p.m., Anand Mazumdar wrote:
> > src/slave/validation.cpp, line 57
> > <https://reviews.apache.org/r/38577/diff/3/?file=1086533#file1086533line57>
> >
> >     Sorry for the ping pong iterations on this but noticed another missing validation
check for `Call::UPDATE` while working on MESOS-3480.
> >     
> >     Can we also check if `TaskState` is not `TASK_STAGING` and return an validation
error if so ?
> >     
> >     https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L2838

This introduces a change of behavior, I'll reflect this on the design Doc too.


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review101003
-----------------------------------------------------------


On Sept. 29, 2015, 8:15 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 8:15 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-2906
>     https://issues.apache.org/jira/browse/MESOS-2906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 891f951 
>   src/Makefile.am 8aa4566 
>   src/slave/http.cpp f9cf7bb 
>   src/slave/validation.hpp PRE-CREATION 
>   src/slave/validation.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38577/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message