mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 38577: Added synchronous validation for Call in Agent
Date Tue, 29 Sep 2015 20:10:09 GMT


> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 501
> > <https://reviews.apache.org/r/38577/diff/2/?file=1080351#file1080351line501>
> >
> >     I think you'll make Alex happy if you also update the corresponding CMake file(s).
> 
> Isabel Jimenez wrote:
>     We don't have cmake support for the agent yet.
> 
> Alex Clemmer wrote:
>     I'm pleased to report that we do, actually! Could we please put this line in the
`CMakeLists.txt` found in `src/`.
> 
> Alex Clemmer wrote:
>     (I should mention that the reason I didn't appear earlier to remind you is because
this was only checked in a day or so ago.)

Great news!


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review100653
-----------------------------------------------------------


On Sept. 29, 2015, 8 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 8 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-2906
>     https://issues.apache.org/jira/browse/MESOS-2906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8aa4566 
>   src/slave/http.cpp cddc8ad 
>   src/slave/validation.hpp PRE-CREATION 
>   src/slave/validation.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38577/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message