mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 37703: Add docker exec command.
Date Tue, 29 Sep 2015 01:24:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review100914
-----------------------------------------------------------



src/docker/docker.cpp (line 1164)
<https://reviews.apache.org/r/37703/#comment158177>

    We're now supporting optional docker socket (-H), if you look at other commands.
    
    Perhaps we should make this into a helper function so we don't have to do this in every
command.


- Timothy Chen


On Sept. 9, 2015, 9:15 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 9:15 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3291
>     https://issues.apache.org/jira/browse/MESOS-3291
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add docker exec command.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp aaf8884a20901ad3a440d545d4b6316b87fc3403 
>   src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
>   src/tests/containerizer/docker_tests.cpp babc7d8da4ed9d13b14bd69decd7f27fc7dfde89 
> 
> Diff: https://reviews.apache.org/r/37703/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message