mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.
Date Tue, 29 Sep 2015 00:51:21 GMT


> On Sept. 29, 2015, 12:31 a.m., Ben Mahler wrote:
> > src/slave/containerizer/docker.cpp, lines 926-928
> > <https://reviews.apache.org/r/38828/diff/1/?file=1086194#file1086194line926>
> >
> >     I believe these were in place to terminate the subprocess, so perhaps a killtree
with SIGTERM would be more appropriate to replace these with.. thoughts? Perhaps reach out
to tim chen for this code.
> 
> Chi Zhang wrote:
>     Yeah, I checked the mesos containerizer code, which in case just returns a failure
and waits for the slave to issue destroy when it gets the failure, but I will pull Tim in.

Hi Tim, could you take a look at this patch please?


- Chi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100908
-----------------------------------------------------------


On Sept. 29, 2015, 12:50 a.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2015, 12:50 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: mesos-3519
>     https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The slave will destroy executors that are not launched successfully, which will
> close all open file descriptors, thus the extra close is not needed.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94 
> 
> Diff: https://reviews.apache.org/r/38828/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message