mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 38814: add test cases for sha512 digest verifier
Date Tue, 29 Sep 2015 00:19:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38814/#review100893
-----------------------------------------------------------



3rdparty/libprocess/src/tests/digest_tests.cpp (line 82)
<https://reviews.apache.org/r/38814/#comment158147>

    You might have to use the TemporaryDrectoryTest fixture for this test and any test related
to creating temporary file.



3rdparty/libprocess/src/tests/digest_tests.cpp (line 96)
<https://reviews.apache.org/r/38814/#comment158162>

    This was a bug in my test. Please see my latest tests.



3rdparty/libprocess/src/tests/digest_tests.cpp (line 121)
<https://reviews.apache.org/r/38814/#comment158163>

    same as above


- Jojy Varghese


On Sept. 28, 2015, 6:06 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38814/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 6:06 p.m.)
> 
> 
> Review request for mesos, Jojy Varghese and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> add test cases for sha512 digest verifier
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38814/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu 14.04)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message