mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.
Date Mon, 28 Sep 2015 22:50:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: mesos-3519
    https://issues.apache.org/jira/browse/mesos-3519


Repository: mesos


Description
-------

The slave will destroy executors that are not launched successfully, which will
close all open file descriptors, thus the extra close is not needed.


Diffs
-----

  src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94 

Diff: https://reviews.apache.org/r/38828/diff/


Testing
-------

make check


Thanks,

Chi Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message