mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.
Date Mon, 28 Sep 2015 18:03:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38809/#review100831
-----------------------------------------------------------



3rdparty/libprocess/src/socket.cpp (line 40)
<https://reviews.apache.org/r/38809/#comment158076>

    "socketfd.isNone()" would be more readable, IMHO.



3rdparty/libprocess/src/socket.cpp (line 77)
<https://reviews.apache.org/r/38809/#comment158079>

    Why is this conditional on socketFd?



3rdparty/libprocess/src/socket.cpp (line 89)
<https://reviews.apache.org/r/38809/#comment158080>

    Same as above.


- Neil Conway


On Sept. 28, 2015, 5:25 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38809/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 5:25 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3519
>     https://issues.apache.org/jira/browse/MESOS-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> socket: refactor to use Option and fix file descriptor leaks.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp a677e29b28711fc065134c11792b4f62fa3aa8b4

>   3rdparty/libprocess/src/socket.cpp 5879423bd92c5805353a962cbd822a993b0568c5 
> 
> Diff: https://reviews.apache.org/r/38809/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message