mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.
Date Sat, 26 Sep 2015 22:08:02 GMT


> On Sept. 25, 2015, 7:07 a.m., Alex Clemmer wrote:
> > cmake/CompilationConfigure.cmake, line 97
> > <https://reviews.apache.org/r/38755/diff/1/?file=1084612#file1084612line97>
> >
> >     Oh yeah. I forgot to remove these. I don't actually know what `pkglibexecdir`
does in autoconf; I'll look it up tomorrow if no one mentions it before I get back to these
reviews. :)

Please pay close attention to this. I only _think_ I got it right.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38755/#review100554
-----------------------------------------------------------


On Sept. 26, 2015, 10:05 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38755/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Move compiler configuration logic to its own file.
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake PRE-CREATION 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38755/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message