mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.
Date Sat, 26 Sep 2015 06:09:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38549/#review100735
-----------------------------------------------------------

Ship it!


This is a big decision because on linux right now the default is libev. The code paths are
significantly different between libev and libevent.
hausdorff is going to follow up with a JIRA for this, and force users to compile with the
--enable-libevent flag. It will error otherwise. This is a nice compromise to ensure that
users understand the decision point.


3rdparty/cmake/Versions.cmake (line 7)
<https://reviews.apache.org/r/38549/#comment157989>

    todo for compiling non-beta version of libevent



CMakeLists.txt (line 37)
<https://reviews.apache.org/r/38549/#comment157988>

    comment about difference of default from linux


- Joris Van Remoortere


On Sept. 21, 2015, 6:31 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38549/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3380
>     https://issues.apache.org/jira/browse/MESOS-3380
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos will need to use libevent to build the process library on Windows.
> 
> This commit will add a default version of libevent, which we will
> eventually retrieve from the 3rdparty GitHub repository, which for now
> is our "official" distribution channel for out-of-band third-party
> dependencies (especially on Windows, which has no package manager).
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Versions.cmake PRE-CREATION 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
> 
> Diff: https://reviews.apache.org/r/38549/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message