mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <cw...@twopensource.com>
Subject Re: Review Request 37540: Add perf event API
Date Sat, 26 Sep 2015 00:16:19 GMT


> On Sept. 25, 2015, 9:53 p.m., Vinod Kone wrote:
> > src/linux/perf.hpp, line 110
> > <https://reviews.apache.org/r/37540/diff/7/?file=1077024#file1077024line110>
> >
> >     put the braces on the same line. more importantly, do you actually need a default
constructor?
> >     
> >     also, do you want this class to be copyable or assignable? if not, make those
constructors private too.

I don't need a default constructor, just need to prevent users using it like "PerfEvent event;",
that is calling create() is the only way to construct it. Not sure if I need to make more
constructors here since create() returns a (smart) pointer.


> On Sept. 25, 2015, 9:53 p.m., Vinod Kone wrote:
> > src/linux/perf.cpp, line 532
> > <https://reviews.apache.org/r/37540/diff/7/?file=1077025#file1077025line532>
> >
> >     i would move this function close to _create(), where it is used.

It would be used by other patch (for MESOS-3399) too. Also, not sure if we gain more readability
by moving it, since that would be put it between two PerfEvent member function definitions.


> On Sept. 25, 2015, 9:53 p.m., Vinod Kone wrote:
> > src/linux/perf.cpp, line 570
> > <https://reviews.apache.org/r/37540/diff/7/?file=1077025#file1077025line570>
> >
> >     1 blank line.

Fixed. And opened https://issues.apache.org/jira/browse/MESOS-3523 for future.


- Cong


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review100656
-----------------------------------------------------------


On Sept. 18, 2015, 10:11 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37540/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 10:11 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2769
>     https://issues.apache.org/jira/browse/MESOS-2769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Abstract Linux kernel perf event API and provide API to collect schedule events.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5 
>   src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a 
>   src/tests/containerizer/perf_tests.cpp ed5212ee31b8aa47339b8b8fab184bbdf85be82a 
> 
> Diff: https://reviews.apache.org/r/37540/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message