mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38416: Allow HTTP response codes to be checked with code.
Date Fri, 25 Sep 2015 22:52:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38416/#review100711
-----------------------------------------------------------



3rdparty/libprocess/include/process/http.hpp (lines 58 - 59)
<https://reviews.apache.org/r/38416/#comment157969>

    How about just status()?
    
    We can also avoid Option here by just returning the number value with no message? That
seems cleaner?



3rdparty/libprocess/include/process/http.hpp (line 396)
<https://reviews.apache.org/r/38416/#comment157970>

    Seems unintuitive to use the StatusCode enum type here, given the value may lie outside
the set of enum values?



3rdparty/libprocess/src/http.cpp (lines 72 - 157)
<https://reviews.apache.org/r/38416/#comment157968>

    Whoa, instead of the giant switch can we keep the map, but avoid the duplicate information?
    
    E.g.
    
    ```
    statuses[StatusCode::OK] = "200 OK"
    ```
    
    Possibly even avoiding the need to write 200 here, e.g.
    
    ```
    statuses[StatusCode::OK] = stringify(StatusCode::OK) + " OK"
    ```


- Ben Mahler


On Sept. 25, 2015, 10:38 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38416/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 10:38 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Jie Yu, Jojy Varghese, and Jiang
Yan Xu.
> 
> 
> Bugs: MESOS-3429
>     https://issues.apache.org/jira/browse/MESOS-3429
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allow HTTP response codes to be checked with code.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2

>   3rdparty/libprocess/src/decoder.hpp 67a5135f302153e376e8dfe8db82aa0b15449389 
>   3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4 
>   3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 97c81b8e61a75771e5bf7d46505cec4e0c0f404a

>   3rdparty/libprocess/src/tests/http_tests.cpp d0b9399d38fa284466a012a21080b1d9007af98b

>   3rdparty/libprocess/src/tests/process_tests.cpp 1023500ac2e3c55be955c4686e7f720eba6b4cc9

> 
> Diff: https://reviews.apache.org/r/38416/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message