mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 38577: Added synchronous validation for Call in Agent
Date Fri, 25 Sep 2015 18:57:59 GMT


> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote:
> > src/slave/validation.hpp, line 36
> > <https://reviews.apache.org/r/38577/diff/2/?file=1080353#file1080353line36>
> >
> >     Can you please add tests in this patch?

Adding tests in a separate dependant patch.


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review100653
-----------------------------------------------------------


On Sept. 22, 2015, 9:46 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 9:46 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-2906
>     https://issues.apache.org/jira/browse/MESOS-2906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e224060 
>   src/slave/http.cpp 12a4d39 
>   src/slave/validation.hpp PRE-CREATION 
>   src/slave/validation.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38577/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message