mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.
Date Fri, 25 Sep 2015 18:35:24 GMT


> On Sept. 25, 2015, 4:58 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake, lines 109-126
> > <https://reviews.apache.org/r/38753/diff/1/?file=1084606#file1084606line109>
> >
> >     Just to clarify.  You're getting rid of this because of haosdent's VS build
script right?

Sorry, are you talking about the comment?

If so, yep, the comment is gone because of the VS build script.

If you're talking about the libraries here, those have been moved to convenience variables
like `GLOG_INCLUDE_DIR`.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/#review100605
-----------------------------------------------------------


On Sept. 25, 2015, 6:19 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38753/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 6:19 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Transition Stout tests to use new third-party build scripts.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 08325297ceb79b80c305ba4f2164ffd37591a0e8

> 
> Diff: https://reviews.apache.org/r/38753/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message