mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 38338: Enhanced option for Docker cli volume plugin.
Date Fri, 25 Sep 2015 18:31:59 GMT


> On Sept. 25, 2015, 6:18 p.m., Timothy Chen wrote:
> > Can you add a test for this logic?

Could, but because volume-driver depends on flocker, my test ideas for this is verify the
docker run command is correct.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38338/#review100643
-----------------------------------------------------------


On Sept. 25, 2015, 1:12 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38338/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 1:12 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3392
>     https://issues.apache.org/jira/browse/MESOS-3392
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enhanced option for Docker cli volume plugin.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
> 
> Diff: https://reviews.apache.org/r/38338/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message