mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.
Date Fri, 25 Sep 2015 18:26:35 GMT


> On Sept. 25, 2015, 4:46 p.m., Artem Harutyunyan wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 242
> > <https://reviews.apache.org/r/38539/diff/2/?file=1078407#file1078407line242>
> >
> >     This surpasses 80 character limit, is there a way to fix it here and elsewhere
in this file?
> 
> Alex Clemmer wrote:
>     I chose not to do this because the Google C++ style guide seems to say that raw string
literals can go over 80 characters. Per our conversation, hopefully Joris can give guidance
here?

Per conversation with Joris, this should be `nolint`'d.


> On Sept. 25, 2015, 4:46 p.m., Artem Harutyunyan wrote:
> > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat, line 34
> > <https://reviews.apache.org/r/38539/diff/2/?file=1078408#file1078408line34>
> >
> >     Ditto.

The solution to this problem is to add a carot in a particular place on this line, so that
we can split it up. Any other place seems to cause compilation to fail. The joy of batch scripting!

(Though, in batch's defense, bash is definitely not a better language.)


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38539/#review100596
-----------------------------------------------------------


On Sept. 21, 2015, 6:14 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38539/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 6:14 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3434
>     https://issues.apache.org/jira/browse/MESOS-3434
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> This commit is the product of two reviews; the first one[1], by
> haosdent, was lightly rebased by hausdorff to target a later HEAD, and
> then augmented to fix the broken Ubuntu 14.04 build that this commit
> caused. Other than those things, the review is functionally identical to
> the original, and all credit for the work should go to haosdent.
> 
> [1] Original review: https://reviews.apache.org/r/37273
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d

>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38539/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message