mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.
Date Fri, 25 Sep 2015 17:39:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38756/#review100625
-----------------------------------------------------------



src/CMakeLists.txt (lines 34 - 38)
<https://reviews.apache.org/r/38756/#comment157844>

    This seems macro-able.
    
    A macro which would let you do something like:
    ```
    BUILD_PROTO(MESOS)
    BUILD_PROTO(V1_MESOS)
    BUILD_PROTO(AUTHENTICATION)
    ...
    ```



src/cmake/MesosProtobuf.cmake (lines 17 - 22)
<https://reviews.apache.org/r/38756/#comment157845>

    Also looks macro-able.
    
    i.e.
    ```
    DEFINE_PROTO_SOURCES(MESOS    /mesos/mesos)
    DEFINE_PROTO_SOURCES(V!_MESOS /mesos/v1/mesos)
    ...
    ```


- Joseph Wu


On Sept. 24, 2015, 11:20 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38756/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 11:20 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3385
>     https://issues.apache.org/jira/browse/MESOS-3385
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add support for compiling the agent with CMake.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
>   src/CMakeLists.txt PRE-CREATION 
>   src/cmake/MesosProtobuf.cmake PRE-CREATION 
>   src/slave/cmake/AgentConfigure.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38756/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message