mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 37993: Add explanatory comments for Allocator interface
Date Fri, 25 Sep 2015 17:23:30 GMT


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > Looking almost perfect! Really appreciate that you diligently address all the comments
I throw into you and don't give up.
> > 
> > While you're touching this file, I would say it makes sense to clean up everything
we can in one patch. Here are some suggestions:
> > - Wrap all types and variables in comments in backticks;
> > - As I've mentioned in one of my previous reviews, let's use the same tense everywhere
in the commens for consistency;
> > - Not a native speaker, but I think we should consolidate the use of articles when
referencing allocator in comments. I think "an allocator" makes more sense since it is explicitly
indicates that it's implementation dependent and not tied to a particular implementation;
> > - Again, not a native speaker, but let's refer to a framework as "which" or "that",
not "who".

Thanks Alex for the review, I found that there are new interfaces added to allocator and will
add comments for the new interface later. You can take a look the updated patch to see if
there are anything need improvement. ;-)


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review100393
-----------------------------------------------------------


On 九月 25, 2015, 5:22 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> -----------------------------------------------------------
> 
> (Updated 九月 25, 2015, 5:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.
> 
> 
> Bugs: MESOS-2224
>     https://issues.apache.org/jira/browse/MESOS-2224
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add explanatory comments for Allocator interface
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp 8100f14220599247a340c919a03f29755b5349d8 
> 
> Diff: https://reviews.apache.org/r/37993/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message