mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 37993: Add explanatory comments for Allocator interface
Date Fri, 25 Sep 2015 17:21:41 GMT


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, line 54
> > <https://reviews.apache.org/r/37993/diff/10/?file=1077928#file1077928line54>
> >
> >     I think you killed that line in previous versions of the review, why do you
want to bring it back?

removed.


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, lines 60-61
> > <https://reviews.apache.org/r/37993/diff/10/?file=1077928#file1077928line60>
> >
> >     Not yours, but let's wrap all types and variable names in backticks "`"

Not quite catch your point, can you please show more detail for what does this mean?


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, line 291
> > <https://reviews.apache.org/r/37993/diff/10/?file=1077928#file1077928line291>
> >
> >     s/time/interval

I was using "time interval" here, hope it is OK.


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, lines 270-271
> > <https://reviews.apache.org/r/37993/diff/10/?file=1077928#file1077928line270>
> >
> >     Again, I'm afraid the next engineer to update the set of offer operations will
forget to update this list. Do you think it's valuable to keep this list here explicitly?

Agree,  I have removed the list here.


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, lines 151-152
> > <https://reviews.apache.org/r/37993/diff/10/?file=1077928#file1077928line151>
> >
> >     I'm a bit hesitant to put a reference to the built-in allocator here. The behaviour
you describe is correct, but 
> >     1) It's how the built-in allocator works
> >     2) It's how the built-in allocator works now: when it the behaviour changes,
my bet is that this comment won't be updated, hence it will become misleading.
> >     
> >     What do you think?

Yes, I have removed this part.


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, line 162
> > <https://reviews.apache.org/r/37993/diff/10/?file=1077928#file1077928line162>
> >
> >     s/new agent joins the Mesos cluster or in the case of a agent recovery./new
agent joins the cluster or in case of agent recovery.
> >     
> >     not a native speaker though

updated.


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, line 183
> > <https://reviews.apache.org/r/37993/diff/10/?file=1077928#file1077928line183>
> >
> >     s/should/are

I was replacing "should be" to "is", hope it is ok.


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, line 193
> > <https://reviews.apache.org/r/37993/diff/10/?file=1077928#file1077928line193>
> >
> >     What do you mean by "new" here? New feature or new update?

new update, updated the comments here as: Updates the latest ....


> On 九月 24, 2015, 4:35 p.m., Alexander Rukletsov wrote:
> > include/mesos/master/allocator.hpp, lines 247-250
> > <https://reviews.apache.org/r/37993/diff/10/?file=1077928#file1077928line247>
> >
> >     Suggestion:
> >     
> >     A framework may request resources via this call. It is up to an allocator how
to react to this request. For example, a request may be ignored, or may influence internal
priorities an allocator may keep for frameworks.

Done.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review100393
-----------------------------------------------------------


On 九月 25, 2015, 4:21 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> -----------------------------------------------------------
> 
> (Updated 九月 25, 2015, 4:21 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.
> 
> 
> Bugs: MESOS-2224
>     https://issues.apache.org/jira/browse/MESOS-2224
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add explanatory comments for Allocator interface
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp 8100f14220599247a340c919a03f29755b5349d8 
> 
> Diff: https://reviews.apache.org/r/37993/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message