mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.
Date Fri, 25 Sep 2015 16:58:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38753/#review100605
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake (line 97)
<https://reviews.apache.org/r/38753/#comment157826>

    Just to clarify.  You're getting rid of this because of haosdent's VS build script right?



3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake (lines 113 - 117)
<https://reviews.apache.org/r/38753/#comment157825>

    Looks like you don't need this comment anymore.


- Joseph Wu


On Sept. 24, 2015, 11:19 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38753/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Transition Stout tests to use new third-party build scripts.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 08325297ceb79b80c305ba4f2164ffd37591a0e8

> 
> Diff: https://reviews.apache.org/r/38753/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message