mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 37197: Docker image store.
Date Fri, 25 Sep 2015 16:37:37 GMT


> On Sept. 3, 2015, 6:16 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/store.hpp, line 49
> > <https://reviews.apache.org/r/37197/diff/12/?file=1056928#file1056928line49>
> >
> >     Is this intended to be an abstract class? If so, why this factory method?

It's going to be used in a factory therefore we created this, as users can choose which store
to use. And yes it's intended to be abstract.


> On Sept. 3, 2015, 6:16 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/store.hpp, line 51
> > <https://reviews.apache.org/r/37197/diff/12/?file=1056928#file1056928line51>
> >
> >     What is the ownership model for fetcher pointer. By ownership I mean how is
the lifecycle of the pointer managed?

Good question, it's passed all the way from provisioner factory interface, and assumed to
be owned external. 
We can leave a TODO on the provisioner provision interface to fix this later.


> On Sept. 3, 2015, 6:16 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/store.hpp, line 55
> > <https://reviews.apache.org/r/37197/diff/12/?file=1056928#file1056928line55>
> >
> >     I think all new code needs to follow mesos doxygen guidelines.

It is in the latest review.


> On Sept. 3, 2015, 6:16 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/store.hpp, line 93
> > <https://reviews.apache.org/r/37197/diff/12/?file=1056928#file1056928line93>
> >
> >     According to http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Declaration_Order,
the non-copyable/non-assignable section should be last in the declaration order.

It is in the latest review.


> On Sept. 3, 2015, 6:16 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioners/docker/store.cpp, line 150
> > <https://reviews.apache.org/r/37197/diff/12/?file=1056929#file1056929line150>
> >
> >     calls for a static constant?

It is in the latest review.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/#review97598
-----------------------------------------------------------


On Aug. 27, 2015, 11:39 p.m., Lily Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37197/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 11:39 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, Till Toenshoff, and Timothy
Chen.
> 
> 
> Bugs: MESOS-2849
>     https://issues.apache.org/jira/browse/MESOS-2849
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stored images currently kept indefinitely.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 7b620ff66856b3f0adac121b3297d55ed71a3d99 
>   src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION 
>   src/slave/flags.hpp e56738e2dfd6593ef8f093687919da287af78f77 
>   src/slave/flags.cpp b36710d6d7a7250bc071a57310a2d54bfb3bc624 
> 
> Diff: https://reviews.apache.org/r/37197/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Lily Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message