mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).
Date Fri, 25 Sep 2015 16:35:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review100588
-----------------------------------------------------------


One more thing: when the patch fails to apply, I get this message:

```
Traceback (most recent call last):
  File "support/apply-reviews.py", line 86, in <module>
    apply_review(r, dry_run)
  File "support/apply-reviews.py", line 60, in apply_review
    shell(cmd)
  File "support/apply-reviews.py", line 53, in shell
    command, stderr=subprocess.STDOUT, shell=True)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line
573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command './support/apply-review.sh -n -r 38752' returned non-zero
exit status 1
```

Instead of this one:
```
2015-09-25 09:34:05 URL:https://reviews.apache.org/r/38752/diff/raw/ [1426/1426] -> "38752.patch"
[1]
error: patch failed: 3rdparty/libprocess/3rdparty/CMakeLists.txt:87
error: 3rdparty/libprocess/3rdparty/CMakeLists.txt: patch does not apply
error: patch failed: cmake/MesosConfigure.cmake:114
error: cmake/MesosConfigure.cmake: patch does not apply
Failed to apply patch
```

- Joseph Wu


On Sept. 23, 2015, 9:26 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 9:26 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
>     https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message