mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 38541: CMake: Add `Versions.cmake` as an analog to `versions.am`.
Date Fri, 25 Sep 2015 16:11:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38541/#review100584
-----------------------------------------------------------

Ship it!


Ship It!

- haosdent huang


On Sept. 21, 2015, 6:25 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38541/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As we prepare to add more third-party dependencies, it will be helpful
> to have all the version information of our third-party dependencies in
> one place, rather than scattered everywhere in the project.
> 
> This commit will introduce `Versions.cmake`, which will hold all this
> information.
> 
> 
> Diffs
> -----
> 
>   3rdparty/cmake/Versions.cmake PRE-CREATION 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
> 
> Diff: https://reviews.apache.org/r/38541/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message