mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.
Date Fri, 25 Sep 2015 07:06:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38756/#review100553
-----------------------------------------------------------


Bad patch!

Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, 38541, 38542, 38549,
38550, 38551, 38552, 38751, 38752]

Failed command: ./support/apply-review.sh -n -r 38752

Error:
 2015-09-25 07:06:43 URL:https://reviews.apache.org/r/38752/diff/raw/ [1426/1426] -> "38752.patch"
[1]
Successfully applied: CMake: Transition Mesos to use new third-party build scripts.

CMake: Transition Mesos to use new third-party build scripts.


Review: https://reviews.apache.org/r/38752
No files to lint

ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  cmake/MesosConfigure.cmake
libprocess:
  3rdparty/libprocess/3rdparty/CMakeLists.txt
Failed to commit patch

- Mesos ReviewBot


On Sept. 25, 2015, 6:20 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38756/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2015, 6:20 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3385
>     https://issues.apache.org/jira/browse/MESOS-3385
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add support for compiling the agent with CMake.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
>   src/CMakeLists.txt PRE-CREATION 
>   src/cmake/MesosProtobuf.cmake PRE-CREATION 
>   src/slave/cmake/AgentConfigure.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38756/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message