mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Review Request 38731: Make common resources symmetrical to v1 resources.
Date Thu, 24 Sep 2015 20:20:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38731/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Bugs: MESOS-3510
    https://issues.apache.org/jira/browse/MESOS-3510


Repository: mesos


Description
-------

This aids in verifying the files are kept in sync.
diff src/common/resources.cpp src/v1/resources.cpp should result
in only include and namespace differences.


Diffs
-----

  src/common/resources.cpp abfc6f34cd444cab7c95c2706a408ec9d3a66025 
  src/v1/resources.cpp dc868903472f8f3a1ddc56092e3f8f81d953ce39 

Diff: https://reviews.apache.org/r/38731/diff/


Testing
-------

diff src/common/resources.cpp src/v1/resources.cpp
```
27,29c27,29
< #include <mesos/resources.hpp>
< #include <mesos/values.hpp>
< #include <mesos/type_utils.hpp>
---
> #include <mesos/v1/mesos.hpp>
> #include <mesos/v1/resources.hpp>
> #include <mesos/v1/values.hpp>
43a44
> namespace v1 {
1263a1265
> } // namespace v1 {
```


Thanks,

Joris Van Remoortere


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message