mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38137: Added Docker provisioner, store and local puller
Date Thu, 24 Sep 2015 19:34:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38137/#review100452
-----------------------------------------------------------

Ship it!


LGTM! Let's get this committed!


src/slave/containerizer/provisioner/docker/local_puller.cpp (lines 126 - 127)
<https://reviews.apache.org/r/38137/#comment157646>

    This is a little jagged, how about:
    ```
    VLOG(1) << "Untarring image from '" << directory
            << "' to '" << tarPath << "'";
    ```



src/slave/containerizer/provisioner/docker/local_puller.cpp (line 167)
<https://reviews.apache.org/r/38137/#comment157647>

    This is a local helper, right? Please make it a 'static' function.



src/slave/containerizer/provisioner/docker/local_puller.cpp (lines 260 - 269)
<https://reviews.apache.org/r/38137/#comment157648>

    This can be done in parallel as well, right?



src/slave/containerizer/provisioner/docker/local_puller.cpp (line 287)
<https://reviews.apache.org/r/38137/#comment157649>

    Insert a new line above.



src/slave/containerizer/provisioner/docker/local_puller.cpp (line 299)
<https://reviews.apache.org/r/38137/#comment157650>

    Is this necessary?



src/slave/containerizer/provisioner/docker/local_puller.cpp (line 342)
<https://reviews.apache.org/r/38137/#comment157651>

    insert a new line above.



src/slave/containerizer/provisioner/docker/metadata_manager.cpp (line 172)
<https://reviews.apache.org/r/38137/#comment157645>

    No need for mesos::internal::slave?



src/slave/containerizer/provisioner/docker/metadata_manager.cpp (lines 192 - 193)
<https://reviews.apache.org/r/38137/#comment157652>

    This fits in one line?



src/tests/containerizer/provisioner_docker_tests.cpp (line 700)
<https://reviews.apache.org/r/38137/#comment157653>

    2 blank lines above.


- Jie Yu


On Sept. 24, 2015, 9:21 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38137/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 9:21 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Joining all the commits around provisioner and local store into one review so it's easier
to review, as patches
> are changing code on top of each other.
> 
> All the commits are going to committed together.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 776483b 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.proto PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp 35d1199 
>   src/slave/flags.hpp 3f6601a 
>   src/slave/flags.cpp 69976d7 
>   src/tests/containerizer/provisioner_docker_tests.cpp 1b0c304 
> 
> Diff: https://reviews.apache.org/r/38137/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message