mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <cw...@twopensource.com>
Subject Re: Review Request 38699: stout: use os::close everywhere.
Date Thu, 24 Sep 2015 02:19:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38699/#review100344
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp (line 266)
<https://reviews.apache.org/r/38699/#comment157536>

    I must miss something too obvious, but... doesn't os::close() return a Try<Nothing>?
How could that be compared with -1?


- Cong Wang


On Sept. 24, 2015, 12:21 a.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38699/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 12:21 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: mesos-2768
>     https://issues.apache.org/jira/browse/mesos-2768
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> stout: use os::close everywhere.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 7eb51e8771e95f57548fc35753e75c6d56cd97cd

> 
> Diff: https://reviews.apache.org/r/38699/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message