mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.
Date Thu, 24 Sep 2015 00:41:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38634/#review100330
-----------------------------------------------------------

Ship it!



src/linux/systemd.cpp (line 59)
<https://reviews.apache.org/r/38634/#comment157514>

    Let's use tokenization and numify to avoid implicit assumptions and execeptions being
thrown:
    
    vector<string> tokens = strings::tokenize(...);
    
    if (tokens.size() != ...) [
      LOG(WARNING) << "Expecting ...";
      return false;
    }
    
    string name = tokens[0];
    
    Try<int> version = numify<int>(tokens[1]);



src/linux/systemd.cpp (line 91)
<https://reviews.apache.org/r/38634/#comment157515>

    Maybe say "... your mileage may vary, but since some distributions have patched systemd
pacakges available .... we're going to keep running, weeeeeee!".


- Benjamin Hindman


On Sept. 23, 2015, 10:59 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38634/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 10:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen,
Thomas Rampelberg, and Timothy Chen.
> 
> 
> Bugs: MESOS-3425
>     https://issues.apache.org/jira/browse/MESOS-3425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used to perform Systemd specific actions.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 74c1154b2a0a7a91d67be67dd32137eeaf153896 
>   src/linux/systemd.hpp PRE-CREATION 
>   src/linux/systemd.cpp PRE-CREATION 
>   src/slave/containerizer/linux_launcher.hpp f6112c98ffcc46ebcaf5581e821d5481d2f6b494

>   src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4

> 
> Diff: https://reviews.apache.org/r/38634/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message