mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <>
Subject Re: Review Request 38473: Add flag to disable hostname lookup.
Date Wed, 23 Sep 2015 23:10:11 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 23, 2015, 11:10 p.m.)

Review request for mesos, Benjamin Hindman, Cody Maloney, and Neil Conway.


Addressed benh comments

Bugs: MESOS-3457

Repository: mesos


Under certain circumstances, dynamic lookup of hostname, while
successful, provides undesirable results; we would also like, in
those circumstances, be able to just set the hostname to the chosen
IP address (possibly set via the --ip_discovery_command method).

The flag we add here, --[no]-hostname_lookup is `true` by default
(which is the existing behavior) and will work under most
circumstances: however, by disabling lookup (using, for example,
--no_hostname_lookup) the hostname used will be the same as the
one configured (possibly, via --ip or MESOS_IP) in `LIBPROCESS_IP`.

This change affects both Master/Agent nodes.

WARNING - the `Address::hostname()` method always does a dynamic
hostname lookup, which may in fact return inconsistent results
wrt the Master's configuration (this is *not* affected by
this change) and should be avoided; use instead
`Master::info()::hostname()` which is always consistent with
the Master's configuration.

Diffs (updated)

  docs/ dd7f4aa806a3c1a8653a0fda9a326a3707308e7c 
  src/master/flags.hpp e4b1df3f5a33049defff4688463274067f1f1ebf 
  src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 
  src/master/master.cpp 0a40bc3509d56cd8824a1eb74989f11c7f7c038b 
  src/slave/flags.hpp b8d6bb4df4bbe0bac72d4b218ec38ad23fa56214 
  src/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117 
  src/slave/slave.cpp 29865ece00fa8bff3054a7f8c87cbf93403405db 
  src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 
  src/tests/master_tests.cpp f26344d39543f65f2b0a94b8ff566836c8256bf7 



make check


Marco Massenzio

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message