mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 38473: Add flag to disable hostname lookup.
Date Wed, 23 Sep 2015 23:00:15 GMT


> On Sept. 23, 2015, 10:01 p.m., Benjamin Hindman wrote:
> > src/tests/master_tests.cpp, line 1127
> > <https://reviews.apache.org/r/38473/diff/5/?file=1079528#file1079528line1127>
> >
> >     I'm not sure what this tests for and if it doesn't actually introduce a potential
source of flakiness? If we keep this, it needs a comment for why we are doing it.

removed - it was there because I was doing a `get()` on it.


> On Sept. 23, 2015, 10:01 p.m., Benjamin Hindman wrote:
> > src/tests/master_tests.cpp, line 1137
> > <https://reviews.apache.org/r/38473/diff/5/?file=1079528#file1079528line1137>
> >
> >     This shouldn't be here right?

this test has been entirely removed - this code path will never be exercised in the new code.


> On Sept. 23, 2015, 10:01 p.m., Benjamin Hindman wrote:
> > src/tests/master_tests.cpp, line 1143
> > <https://reviews.apache.org/r/38473/diff/5/?file=1079528#file1079528line1143>
> >
> >     This test shouldn't fail should it? I think this entire test is no longer valid.

I have a personal ToDO to discover more about EXPECT_EXIT() and its semantics.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38473/#review100296
-----------------------------------------------------------


On Sept. 22, 2015, 12:22 a.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38473/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 12:22 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Neil Conway.
> 
> 
> Bugs: MESOS-3457
>     https://issues.apache.org/jira/browse/MESOS-3457
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Under certain circumstances, dynamic lookup of hostname, while
> successful, provides undesirable results; we would also like, in
> those circumstances, be able to just set the hostname to the chosen
> IP address (possibly set via the --ip_discovery_command method).
> 
> The flag we add here, --[no]-hostname_lookup is `true` by default
> (which is the existing behavior) and will work under most
> circumstances: however, by disabling lookup (using, for example,
> --no_hostname_lookup) the hostname used will be the same as the
> one configured (possibly, via --ip or MESOS_IP) in `LIBPROCESS_IP`.
> 
> This change affects both Master/Agent nodes.
> 
> WARNING - the `Address::hostname()` method always does a dynamic
> hostname lookup, which may in fact return inconsistent results
> wrt the Master's configuration (this is *not* affected by
> this change) and should be avoided; use instead
> `Master::info()::hostname()` which is always consistent with
> the Master's configuration.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md dd7f4aa806a3c1a8653a0fda9a326a3707308e7c 
>   src/master/flags.hpp e4b1df3f5a33049defff4688463274067f1f1ebf 
>   src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 
>   src/master/master.cpp 90ef8c663c90ffbdcb4aa2377bfba65ea5d3fda9 
>   src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 
>   src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f 
>   src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
>   src/tests/cluster.hpp 114583de8c867495a2b7a953e6826708838e5d23 
>   src/tests/master_tests.cpp f26344d39543f65f2b0a94b8ff566836c8256bf7 
> 
> Diff: https://reviews.apache.org/r/38473/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message