mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.
Date Wed, 23 Sep 2015 22:34:00 GMT


> On Sept. 23, 2015, 8:46 a.m., Timothy Chen wrote:
> > src/linux/systemd.cpp, line 54
> > <https://reviews.apache.org/r/38634/diff/2/?file=1081887#file1081887line54>
> >
> >     Just tried to run this in CentOS 7 and I couldn't find /bin/systemd, but systemd
is running.
> 
> Niklas Nielsen wrote:
>     I see :/ So either use the shell's PATH (again) or have fall back locations.

Tested the new version on centos7, centos6, ubuntu15.04, ubuntu14.04, archlinux, coreos


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38634/#review100168
-----------------------------------------------------------


On Sept. 23, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38634/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas Nielsen,
Thomas Rampelberg, and Timothy Chen.
> 
> 
> Bugs: MESOS-3425
>     https://issues.apache.org/jira/browse/MESOS-3425
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will be used to perform Systemd specific actions.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 74c1154b2a0a7a91d67be67dd32137eeaf153896 
>   src/linux/systemd.hpp PRE-CREATION 
>   src/linux/systemd.cpp PRE-CREATION 
>   src/slave/containerizer/linux_launcher.hpp f6112c98ffcc46ebcaf5581e821d5481d2f6b494

>   src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4

> 
> Diff: https://reviews.apache.org/r/38634/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message