mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 38575: Added masterSlaveLostHook
Date Wed, 23 Sep 2015 22:27:35 GMT


> On Sept. 21, 2015, 4:58 p.m., Guangya Liu wrote:
> > include/mesos/hook.hpp, line 66
> > <https://reviews.apache.org/r/38575/diff/1/?file=1078586#file1078586line66>
> >
> >     Do we need to update slave to agent in other comments introduced by this patch?

All code references are now marked with `` and am using Agent otherwise.


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38575/#review99871
-----------------------------------------------------------


On Sept. 23, 2015, 3:24 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38575/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Kapil Arya.
> 
> 
> Bugs: MESOS-3015
>     https://issues.apache.org/jira/browse/MESOS-3015
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new masterSlaveLost hook to enable modules to clean up after lost slaves
events (as in networking modules, where we want to avoid leaking IPs).
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/master/master.cpp 5ca19412f5e654a8e1e265559a809cfaa2a59014 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38575/diff/
> 
> 
> Testing
> -------
> 
> make check with new masterSlaveLostHook test
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message