mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 38595: Removed implicit logging from Socket::shutdown in favor of returning a Try.
Date Wed, 23 Sep 2015 18:13:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38595/#review100258
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38595/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary, should this also not be an ERROR?
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp a677e29b28711fc065134c11792b4f62fa3aa8b4

>   3rdparty/libprocess/src/libevent_ssl_socket.hpp 3b17fa278a92461cf74179084a717909224c3d9c

>   3rdparty/libprocess/src/libevent_ssl_socket.cpp 80db6e83f14de5fd241565009d8a60aa964e790c

>   3rdparty/libprocess/src/process.cpp 4afa30569b4d235637b49a624602e6b199c32e0e 
> 
> Diff: https://reviews.apache.org/r/38595/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message