mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38452: Updated C++ style guide for namespace usage
Date Wed, 23 Sep 2015 17:47:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38452/#review100240
-----------------------------------------------------------


It seems good to qualify how we're different from the google style guide here. It seems the
main difference is that we avoid the using statements inside functions / classes for the most
part.

Also not your fault but we're talking about namespace aliases and using statements in the
"naming" section, which seems strange.

- Ben Mahler


On Sept. 17, 2015, 8:09 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38452/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 8:09 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3450
>     https://issues.apache.org/jira/browse/MESOS-3450
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated C++ style guide for namespace usage
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md f1ed32aa845f7cfc85d002f4306a3c32e2eeb1d6 
> 
> Diff: https://reviews.apache.org/r/38452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message