mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 38137: Added Docker provisioner, store and local puller
Date Wed, 23 Sep 2015 17:13:37 GMT


> On Sept. 23, 2015, 7:45 a.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/provisioner/docker/local_puller.hpp, line 45
> > <https://reviews.apache.org/r/38137/diff/12/?file=1080142#file1080142line45>
> >
> >     Not a strong opinion but if you think this could potentially be "not local"
(e.g. NFS or HDFS hosting these), you may name it ArchivesPuller because it's more about "what
the image source format is" then "where it is from".
> >     
> >     We don't, of course, need to implement all the remote cases in the first patch.

hmm, for now it's just local :(


> On Sept. 23, 2015, 7:45 a.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/provisioner/docker/local_puller.cpp, line 197
> > <https://reviews.apache.org/r/38137/diff/12/?file=1080143#file1080143line197>
> >
> >     What's the problem with it and is it still a problem with recent JSON related
commits?
> >     
> >     (I have no idea, just would like to check.)

It's a problem since we find fields that's nested with in JSON with syntax "a.b.c", but if
a tag itself has a period such as "14.04", we will try to find 14 first in the object.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38137/#review99919
-----------------------------------------------------------


On Sept. 22, 2015, 10:15 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38137/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 10:15 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Joining all the commits around provisioner and local store into one review so it's easier
to review, as patches
> are changing code on top of each other.
> 
> All the commits are going to committed together.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e224060 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.proto PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp 35d1199 
>   src/slave/flags.hpp e31a418 
>   src/slave/flags.cpp add4196 
>   src/tests/containerizer/provisioner_docker_tests.cpp 1b0c304 
> 
> Diff: https://reviews.apache.org/r/38137/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message