mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 38639: Add os::clone function in stout.
Date Wed, 23 Sep 2015 01:28:31 GMT


> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line73>
> >
> >     We should delete the stack only if CLONE_VM was not specified in the flags or
at least have a comment mentioning the fact that this call is creating a new process and not
a new thread. Having a CLONE_VM will create a new thread, not a new process.
> 
> Jie Yu wrote:
>     Good call! +1
> 
> Jie Yu wrote:
>     Or we can disallow CLONE_VM since if the user wants to create a thread, he/she should
use pthread.
> 
> Kapil Arya wrote:
>     That should work too and is better in my opinion.

Thanks a lot!


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38639/#review100046
-----------------------------------------------------------


On Sept. 23, 2015, 1:26 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38639/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 1:26 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Cong Wang.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add os::clone function in stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp b994b13941628947c9d12b8baae155d5da1ec7bd

> 
> Diff: https://reviews.apache.org/r/38639/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message