mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38645: Fixed Flaky Executor HTTP tests
Date Wed, 23 Sep 2015 00:13:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38645/#review100103
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38645]

All tests passed.

- Mesos ReviewBot


On Sept. 22, 2015, 9:37 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38645/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 9:37 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This showed up on ASF CI. From the logs:
> 
> `I0922 17:31:49.819221 28463 slave.cpp:4104] Finished recoveryā€¯`
> Then ....
> `../../src/tests/executor_http_api_tests.cpp:290: Failure`
> `Failed to wait 15secs for __recover`
> 
> Instead of doing a `FUTURE_DISPATCH` after `StartSlave()` we should be doing it before
starting the slave. In some cases, slave would have already recovered by the time we invoke
`FUTURE_DISPATCH` leading to the flakiness.
> 
> 
> Diffs
> -----
> 
>   src/tests/executor_http_api_tests.cpp 9dbc5191b5950df2faa693720f3740e97c7df758 
> 
> Diff: https://reviews.apache.org/r/38645/diff/
> 
> 
> Testing
> -------
> 
> Introduced a sleep before `AWAIT_READY`, the test failed. After this change with the
sleep it still passed.
> 
> Ran in a loop 100 times.
> 
> ASF CI error log: https://builds.apache.org/job/Mesos/COMPILER=gcc,CONFIGURATION=--verbose,OS=ubuntu%3A14.04,label_exp=docker%7C%7CHadoop/839/changes
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message