mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 38158: Refactored Value::Ranges coalesce().
Date Tue, 22 Sep 2015 20:55:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 8:55 p.m.)


Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till Toenshoff.


Bugs: MESOS-3051
    https://issues.apache.org/jira/browse/MESOS-3051


Repository: mesos


Description
-------

The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior
there was substantial time spend in allocation/destruction (MESOS-3051).


Diffs (updated)
-----

  src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f 
  src/tests/resources_tests.cpp 0318885336409f7cc9dbd4a3daa9b52db197bbd1 
  src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 

Diff: https://reviews.apache.org/r/38158/diff/


Testing
-------

make check


Thanks,

Joerg Schad


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message