mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38137: Added Docker provisioner, store and local puller
Date Tue, 22 Sep 2015 17:29:38 GMT


> On Sept. 21, 2015, 11:22 p.m., Jie Yu wrote:
> > src/slave/containerizer/provisioner/docker/store.cpp, line 256
> > <https://reviews.apache.org/r/38137/diff/9/?file=1078275#file1078275line256>
> >
> >     According to your current design, Store is supposed to be agnostic to which
puller is being used, right? Therefore, there should be local puller specific code in Store.
> >     
> >     Shouldn't the puller interface returns a map: imageId -> path_to_fs_layer
and the Store just looks at the paths and move them to getImageLayerRootfsPath?
> 
> Timothy Chen wrote:
>     I thought about this, but I also want to know the dependencies among layers. So decided
that the simplest is to return the vector of layer IDs, but just expect the layers to be prepared
under the staging directory with the right structure. I've commented on that in the puller
interface.

Have you looked at LinkedHashMap?


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38137/#review99772
-----------------------------------------------------------


On Sept. 22, 2015, 8:22 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38137/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 8:22 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Joining all the commits around provisioner and local store into one review so it's easier
to review, as patches
> are changing code on top of each other.
> 
> All the commits are going to committed together.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e224060 
>   src/slave/containerizer/provisioner/docker/local_puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/local_puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/message.proto PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/metadata_manager.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/paths.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/puller.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/docker/store.cpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp 35d1199 
>   src/slave/flags.hpp e31a418 
>   src/slave/flags.cpp add4196 
>   src/tests/containerizer/provisioner_docker_tests.cpp 1b0c304 
> 
> Diff: https://reviews.apache.org/r/38137/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message