mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 38584: Added a few filesystem isolation and provisioning metrics.
Date Tue, 22 Sep 2015 17:16:31 GMT


> On Sept. 22, 2015, 9:19 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/isolators/filesystem/linux.hpp, line 141
> > <https://reviews.apache.org/r/38584/diff/1/?file=1079551#file1079551line141>
> >
> >     is this proper accordng to style guide (Since this is a public method)?

It's under the private section and the convention used for metrics gauges. e.g. https://github.com/apache/mesos/blob/master/src/master/master.hpp#L1237


> On Sept. 22, 2015, 9:19 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, line 839
> > <https://reviews.apache.org/r/38584/diff/1/?file=1079552#file1079552line839>
> >
> >     const?

You mean "const PID<LinuxFilesystemIsolatorProcess>& isolator"? It's fixed already.
Thanks!


> On Sept. 22, 2015, 9:19 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioner/provisioner.cpp, line 435
> > <https://reviews.apache.org/r/38584/diff/1/?file=1079554#file1079554line435>
> >
> >     const?

What being const?


> On Sept. 22, 2015, 9:19 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/provisioner/provisioner.cpp, line 419
> > <https://reviews.apache.org/r/38584/diff/1/?file=1079554#file1079554line419>
> >
> >     const?

Yeah I guess it won't hurt to use const but the entire usage and lifecyle of this variable
is within 5 lines I didn't feel the need. For more complex logic, for sure. Thanks!


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38584/#review100005
-----------------------------------------------------------


On Sept. 21, 2015, 5:58 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38584/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 5:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3466
>     https://issues.apache.org/jira/browse/MESOS-3466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a few filesystem isolation and provisioning metrics.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 041af7b51cc7da933a929d3beb05c419321ddd73

>   src/slave/containerizer/isolators/filesystem/linux.cpp e821b27d5cba324e434132d884d25a526c11a9c5

>   src/slave/containerizer/provisioner/backends/bind.cpp d853b49891360fbc2eb46f2e7859fa296fd36beb

>   src/slave/containerizer/provisioner/provisioner.cpp 213f8a6cbcfa198920dbb83c42e58e8aef6d6946

>   src/tests/containerizer/filesystem_isolator_tests.cpp e2eb049ae477578caeedaa4251f7ddf9028d3fb5

> 
> Diff: https://reviews.apache.org/r/38584/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message