mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 38584: Added a few filesystem isolation and provisioning metrics.
Date Tue, 22 Sep 2015 16:07:24 GMT


> On Sept. 21, 2015, 11:09 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioner/backends/bind.cpp, line 194
> > <https://reviews.apache.org/r/38584/diff/1/?file=1079553#file1079553line194>
> >
> >     Why only when errno == EBUSY?

Because other errors are not masked by the backend and propagted uptowards and will be reflected
in other metrics.

It's no big deal and we'll likely deprecated these some time later. 

Currently we need these to see how often we get errors due to race condition between containers
cleaning up their mount table and the host destroying these folders.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38584/#review99930
-----------------------------------------------------------


On Sept. 21, 2015, 5:58 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38584/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 5:58 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3466
>     https://issues.apache.org/jira/browse/MESOS-3466
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a few filesystem isolation and provisioning metrics.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 041af7b51cc7da933a929d3beb05c419321ddd73

>   src/slave/containerizer/isolators/filesystem/linux.cpp e821b27d5cba324e434132d884d25a526c11a9c5

>   src/slave/containerizer/provisioner/backends/bind.cpp d853b49891360fbc2eb46f2e7859fa296fd36beb

>   src/slave/containerizer/provisioner/provisioner.cpp 213f8a6cbcfa198920dbb83c42e58e8aef6d6946

>   src/tests/containerizer/filesystem_isolator_tests.cpp e2eb049ae477578caeedaa4251f7ddf9028d3fb5

> 
> Diff: https://reviews.apache.org/r/38584/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message