mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38609: Refactored http::internal::request to use http::connect.
Date Tue, 22 Sep 2015 09:17:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38609/#review99956
-----------------------------------------------------------


Bad patch!

Reviews applied: [38595, 38596, 38597, 38598, 38600, 38599]

Failed command: ./support/apply-review.sh -n -r 38599

Error:
 2015-09-22 09:17:58 URL:https://reviews.apache.org/r/38599/diff/raw/ [11633/11633] ->
"38599.patch" [1]
error: src/slave/containerizer/provisioners/docker/registry_client.cpp: does not exist in
index
Failed to apply patch

- Mesos ReviewBot


On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38609/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gets rid of the duplicated code, in favor of leveraging http::Connection.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2

>   3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4 
> 
> Diff: https://reviews.apache.org/r/38609/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message