mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic
Date Tue, 22 Sep 2015 06:02:43 GMT


> On 九月 21, 2015, 10:08 p.m., Guangya Liu wrote:
> > I think that you need make this patch depend on https://reviews.apache.org/r/38279/
to make this works.
> 
> Felix Abecassis wrote:
>     Thank you, I hope it's fixed now.

I see that this patch is depending on https://reviews.apache.org/r/38279/ , but from review
borad, I see that it is depending on 38517, is that right?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review99841
-----------------------------------------------------------


On 九月 22, 2015, 1:40 a.m., Felix Abecassis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> -----------------------------------------------------------
> 
> (Updated 九月 22, 2015, 1:40 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3366
>     https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/slave/slave.cpp 29865ece00fa8bff3054a7f8c87cbf93403405db 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message