mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.
Date Tue, 22 Sep 2015 05:08:33 GMT


> On Sept. 21, 2015, 11:01 p.m., Ben Mahler wrote:
> > support/verify_reviews.py, line 141
> > <https://reviews.apache.org/r/37914/diff/1/?file=1058949#file1058949line141>
> >
> >     Maybe this should say bad review instead of bad patch?

done.


> On Sept. 21, 2015, 11:01 p.m., Ben Mahler wrote:
> > support/verify_reviews.py, line 142
> > <https://reviews.apache.org/r/37914/diff/1/?file=1058949#file1058949line142>
> >
> >     Is this line necessary for review related errors?

yes. much like for bad patches, this points to which review had the error.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37914/#review99856
-----------------------------------------------------------


On Aug. 29, 2015, 12:08 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37914/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 12:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> I'm seeing more and more reviews being sent without tagging reviewers. This should flag
such reviews to guide new contributors.
> 
> 
> Diffs
> -----
> 
>   support/verify_reviews.py b85a3245b2f248dbdb8e2783f2384092e3d53031 
> 
> Diff: https://reviews.apache.org/r/37914/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> ./support/verify_reviews.py vinod kone 10 "?from-user=neilc"
> git rev-parse HEAD
> Checking if review: 37445 needs verification
> Latest diff timestamp: 2015-08-13 21:01:08
> Verifying review 37445
> Posting review: Bad patch!
> 
> Reviews applied: []
> 
> Error:
>  No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message