mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Abecassis" <fabecas...@nvidia.com>
Subject Re: Review Request 38279: Add a new callback enabling custom resource discovery logic
Date Tue, 22 Sep 2015 02:14:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38279/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 2:14 a.m.)


Review request for mesos, Connor Doyle and Niklas Nielsen.


Summary (updated)
-----------------

Add a new callback enabling custom resource discovery logic


Bugs: MESOS-3366
    https://issues.apache.org/jira/browse/MESOS-3366


Repository: mesos


Description
-------

First API draft for MESOS-3366.

1) Only supports resources for now, we can add another hook for attributes with a very similar
code.
2) The callback currently receives the full SlaveInfo structure and construct a new Resources
object.
3) If there is multiple callbacks, each callback will see the changes made by previous callbacks
and are free to override or merge the detected resources as they see fit.


Diffs
-----

  include/mesos/hook.hpp 2353602 
  src/examples/test_hook_module.cpp 0dc74d6 
  src/hook/manager.hpp a517c05 
  src/hook/manager.cpp 691976e 
  src/slave/slave.cpp 29865ec 
  src/tests/hook_tests.cpp b23a587 

Diff: https://reviews.apache.org/r/38279/diff/


Testing
-------

make clean && make && make check


Thanks,

Felix Abecassis


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message