mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Abecassis" <fabecas...@nvidia.com>
Subject Re: Review Request 38279: Enabled resources/attributes discovery
Date Tue, 22 Sep 2015 01:33:56 GMT


> On Sept. 21, 2015, 7:57 a.m., Guangya Liu wrote:
> > src/tests/hook_tests.cpp, line 659
> > <https://reviews.apache.org/r/38279/diff/2/?file=1077263#file1077263line659>
> >
> >     s/VerifySlaveResourcesHook/VerifySlaveResourcesDiscoverHook/g
> 
> Felix Abecassis wrote:
>     I will rename it to "VerifySlaveInitializationResourcesDecorator" if that's OK, it
will be more consistent with the other tests.
> 
> Guangya Liu wrote:
>     It seems a bit longer, not sure if we can change slaveInitializationResourcesDecorator
to slaveResourcesDecorator? Why you are adding "Initialization" in this function?

That's the name of the hook. Niklas asked me to refine the initial name.


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38279/#review99733
-----------------------------------------------------------


On Sept. 22, 2015, 1:26 a.m., Felix Abecassis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38279/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2015, 1:26 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
>     https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> First API draft for MESOS-3366.
> 
> 1) Only supports resources for now, we can add another hook for attributes with a very
similar code.
> 2) The callback currently receives the full SlaveInfo structure and construct a new Resources
object.
> 3) If there is multiple callbacks, each callback will see the changes made by previous
callbacks and are free to override or merge the detected resources as they see fit.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp 2353602 
>   src/examples/test_hook_module.cpp 0dc74d6 
>   src/hook/manager.hpp a517c05 
>   src/hook/manager.cpp 691976e 
>   src/slave/slave.cpp 29865ec 
>   src/tests/hook_tests.cpp b23a587 
> 
> Diff: https://reviews.apache.org/r/38279/diff/
> 
> 
> Testing
> -------
> 
> make clean && make && make check
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message