mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.
Date Mon, 21 Sep 2015 18:13:42 GMT


> On Sept. 21, 2015, 6:08 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat, line 52
> > <https://reviews.apache.org/r/38539/diff/1/?file=1077772#file1077772line52>
> >
> >     s/not/does not/
> >     s/current/the current/
> >     
> >     And a period at the end.

I'd like to not change "current" to "the current" because that makes the comment go over 80
columns, and it doesn't add clarity.

The other changes have been applied though.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38539/#review99788
-----------------------------------------------------------


On Sept. 21, 2015, 2:40 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38539/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 2:40 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Bugs: MESOS-3434
>     https://issues.apache.org/jira/browse/MESOS-3434
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> This commit is the product of two reviews; the first one[1], by
> haosdent, was lightly rebased by hausdorff to target a later HEAD, and
> then augmented to fix the broken Ubuntu 14.04 build that this commit
> caused. Other than those things, the review is functionally identical to
> the original, and all credit for the work should go to haosdent.
> 
> [1] Original review: https://reviews.apache.org/r/37273
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d

>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38539/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message